sungwy commented on PR #15850: URL: https://github.com/apache/iceberg/pull/15850#issuecomment-4310405122
Hi @adutra, thanks again for this PR. I thought through this more, and I think the decision between `MUST` vs `SHOULD` depends on whether we intend to define a signer protocol contract between the REST catalog, client, and the signer endpoint, versus whether it is just a suggestion to pass along the properties. If the intention is to define a contract, then I think `MUST` is the correct language. In that case though, I think it would be good to socialize that framing a bit more explicitly on the mailing list. While the PR itself was posted there, I think the expected behavior, that clients MUST forward catalog-provided signer properties to the signer endpoint, is important enough to call out directly and get broader alignment. My current read is that this leans closer to REST protocol semantics than a suggestive optimization. I’m supportive of making this an explicit contract, since that gives REST clients a clear propagation responsibility and allows the ecosystem to rely on this behavior consistently. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
