blackmwk commented on PR #2358: URL: https://github.com/apache/iceberg-rust/pull/2358#issuecomment-4311077969
> Thanks for tackling this @blackmwk! My only comment is that I noticed `PredicateConverter` fields are `pub(super)` with `pub(super) column_indices: &'a Vec<usize>`. In the original they were `pub`. This is actually a tightening of visibility, which is fine. I think long term that's the right move, and now I wonder if there's anything else we should tighten visibility on, but for now this looks good. Thanks for reporting, I agree that it's fine for now to make it a crate private api. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
