joyhaldar commented on code in PR #16097:
URL: https://github.com/apache/iceberg/pull/16097#discussion_r3141590592
##########
core/src/test/java/org/apache/iceberg/data/DataTestBase.java:
##########
@@ -101,7 +101,8 @@ protected boolean
allowsWritingNullValuesForRequiredFields() {
required(114, "dec_9_0", Types.DecimalType.of(9, 0)),
required(115, "dec_11_2", Types.DecimalType.of(11, 2)),
required(116, "dec_38_10", Types.DecimalType.of(38, 10)), // maximum
precision
- required(117, "time", Types.TimeType.get()));
+ required(117, "time", Types.TimeType.get()),
+ required(118, "uuid", Types.UUIDType.get()));
Review Comment:
Thank you for your review @Guosmilesmile.
Based on your feedback, I have added `TestFlinkUuidType` covering:
- `UUID` round-trip read across `Avro`, `Parquet`, `ORC` (Generic writer ->
Flink read)
- `UUID` write through Flink writer across all three formats (Flink write ->
Generic read)
- SQL INSERT failing with `fixed[16] cannot be promoted to uuid` across all
three formats
The SQL failure documents what you ran into in your comment, it's at
Iceberg's schema check before reaching the writers this PR fixes IIUC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
