huaxingao commented on code in PR #15964:
URL: https://github.com/apache/iceberg/pull/15964#discussion_r3142896156
##########
spark/v4.0/spark/src/main/java/org/apache/iceberg/spark/SparkTableUtil.java:
##########
@@ -337,7 +337,7 @@ private static SparkPartition toSparkPartition(
serde.nonEmpty() || table.provider().nonEmpty(), "Partition format
should be defined");
String uri = Util.uriToString(locationUri.get());
- String format = serde.nonEmpty() ? serde.get() : table.provider().get();
+ String format = resolveFileFormat(table);
Review Comment:
I think the partition serde
```
Option<String> serde = partition.storage().serde();
```
is silently dropped. Should it be passed to `resolveFileFormat`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
