Govindarajan-D commented on code in PR #15984:
URL: https://github.com/apache/iceberg/pull/15984#discussion_r3147259073
##########
api/src/main/java/org/apache/iceberg/util/StructProjection.java:
##########
@@ -123,7 +123,9 @@ private StructProjection(StructType structType, StructType
projection, boolean a
case STRUCT:
nestedProjections[pos] =
new StructProjection(
- dataField.type().asStructType(),
projectedField.type().asStructType());
+ dataField.type().asStructType(),
+ projectedField.type().asStructType(),
+ allowMissing);
Review Comment:
Yes, the last test
`testCreateAllowMissingPropagatesAllowMissingToNestedStructs catches that.
##########
api/src/main/java/org/apache/iceberg/util/StructProjection.java:
##########
@@ -123,7 +123,9 @@ private StructProjection(StructType structType, StructType
projection, boolean a
case STRUCT:
nestedProjections[pos] =
new StructProjection(
- dataField.type().asStructType(),
projectedField.type().asStructType());
+ dataField.type().asStructType(),
+ projectedField.type().asStructType(),
+ allowMissing);
Review Comment:
Yes, the last test
`testCreateAllowMissingPropagatesAllowMissingToNestedStructs` catches that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
