pvary commented on code in PR #15996: URL: https://github.com/apache/iceberg/pull/15996#discussion_r3153197255
########## flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/maintenance/operator/EqualityConvertDVResolver.java: ########## @@ -0,0 +1,249 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.flink.maintenance.operator; + +import java.io.IOException; +import java.io.UncheckedIOException; +import java.util.List; +import java.util.Map; +import org.apache.flink.annotation.Internal; +import org.apache.flink.streaming.api.operators.AbstractStreamOperator; +import org.apache.flink.streaming.api.operators.TwoInputStreamOperator; +import org.apache.flink.streaming.api.watermark.Watermark; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.DeleteFile; +import org.apache.iceberg.ManifestFile; +import org.apache.iceberg.ManifestFiles; +import org.apache.iceberg.ManifestReader; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.Table; +import org.apache.iceberg.flink.TableLoader; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; +import org.apache.iceberg.util.ContentFileUtil; +import org.apache.iceberg.util.StructLikeUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Collects {@link DVPosition}s from {@link EqualityConvertWorker} instances (input 1) and an {@link + * EqualityConvertPlanResult} from the planner (input 2). On watermark advancement, groups DVs, and + * emits {@link DVMergeCommand}s for parallel {@link EqualityConvertDVMerger} instances. + */ +@Internal +public class EqualityConvertDVResolver extends AbstractStreamOperator<DVMergeCommand> + implements TwoInputStreamOperator<DVPosition, EqualityConvertPlanResult, DVMergeCommand> { + + private static final Logger LOG = LoggerFactory.getLogger(EqualityConvertDVResolver.class); + + private final String tableName; + private final String taskName; + private final int taskIndex; + private final TableLoader tableLoader; + private final String targetBranch; + + private transient Table table; + private transient List<DVPosition> bufferedPositions; + private transient EqualityConvertPlanResult planResult; + private transient boolean hasUpstreamError; + + public EqualityConvertDVResolver( + String tableName, + String taskName, + int taskIndex, + TableLoader tableLoader, + String targetBranch) { + this.tableName = tableName; + this.taskName = taskName; + this.taskIndex = taskIndex; + this.tableLoader = tableLoader; + this.targetBranch = targetBranch; + } + + @Override + public void open() throws Exception { + super.open(); + if (!tableLoader.isOpen()) { + tableLoader.open(); + } + + table = tableLoader.loadTable(); + bufferedPositions = Lists.newArrayList(); + } + + @Override + public void processElement1(StreamRecord<DVPosition> record) { + if (record.getValue().isAbort()) { + hasUpstreamError = true; + } else { + bufferedPositions.add(record.getValue()); + } + } + + @Override + public void processElement2(StreamRecord<EqualityConvertPlanResult> record) { + planResult = record.getValue(); + } + + @Override + public void processWatermark(Watermark mark) throws Exception { + if (planResult != null && mark.getTimestamp() >= planResult.doneTimestamp()) { + if (hasUpstreamError) { + output.collect(new StreamRecord<>(DVMergeCommand.abort())); + } else { + try { + resolveAndEmit(); + } catch (Exception e) { + LOG.error( + "Error resolving DVs for table {} task {}[{}]", tableName, taskName, taskIndex, e); + output.collect(TaskResultAggregator.ERROR_STREAM, new StreamRecord<>(e)); + output.collect(new StreamRecord<>(DVMergeCommand.abort())); + } + } + + bufferedPositions.clear(); + hasUpstreamError = false; + planResult = null; + } + + super.processWatermark(mark); + } + + private void resolveAndEmit() { + if (bufferedPositions.isEmpty()) { + return; + } + + table.refresh(); + + Snapshot mainSnapshot = table.snapshot(targetBranch); Review Comment: What happens if the table has a new commit compared to the one we started with? Can we fail fast? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
