pvary commented on code in PR #15776:
URL: https://github.com/apache/iceberg/pull/15776#discussion_r3154098355
##########
orc/src/main/java/org/apache/iceberg/data/orc/GenericOrcReaders.java:
##########
@@ -56,11 +57,25 @@ public class GenericOrcReaders {
private GenericOrcReaders() {}
+ /**
+ * @deprecated Use {@link #struct(TypeDescription, List, Types.StructType,
Map)} instead. This
+ * method uses position-based binding which may cause field misalignment
in MOR and lineage
+ * scenarios.
+ */
+ @Deprecated
public static OrcValueReader<Record> struct(
List<OrcValueReader<?>> readers, Types.StructType struct, Map<Integer,
?> idToConstant) {
return new StructReader(readers, struct, idToConstant);
}
+ public static OrcValueReader<Record> struct(
+ TypeDescription record,
Review Comment:
Instead of `record` could we use `orcType` or something similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
