xiaoxuandev commented on code in PR #16129:
URL: https://github.com/apache/iceberg/pull/16129#discussion_r3156713977
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIOProperties.java:
##########
@@ -705,6 +739,16 @@ public S3FileIOProperties(Map<String, String> properties) {
properties,
S3_DIRECTORY_BUCKET_LIST_PREFIX_AS_DIRECTORY,
S3_DIRECTORY_BUCKET_LIST_PREFIX_AS_DIRECTORY_DEFAULT);
+ this.isSharedScheduledExecutorEnabled =
+ PropertyUtil.propertyAsBoolean(
+ properties,
+ S3_SHARED_SCHEDULED_EXECUTOR_ENABLED,
+ S3_SHARED_SCHEDULED_EXECUTOR_ENABLED_DEFAULT);
+ this.sharedScheduledExecutorPoolSize =
+ PropertyUtil.propertyAsInt(
+ properties,
+ S3_SHARED_SCHEDULED_EXECUTOR_POOL_SIZE,
Review Comment:
Good point. Since this is a JVM-wide singleton, a per-catalog pool size
tunable doesn't make sense. I'll remove the
`s3.shared-scheduled-executor.pool-size` property and hard-code the pool size
to 5 (the AWS SDK v2 default). The `s3.shared-scheduled-executor.enabled`
toggle is still useful as an escape hatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
