toutane opened a new pull request, #2386:
URL: https://github.com/apache/iceberg-rust/pull/2386
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #2385 .
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
`crates/sqllogictest/Cargo.toml` was missing the `rt-multi-thread` feature
for tokio, while `tests/sqllogictests.rs` calls
`tokio::runtime::Builder::new_multi_thread()` which requires it.
This meant `cargo test -p iceberg-sqllogictest` failed to compile when run
in isolation. The issue was invisible when using `make build`
(`--all-features --workspace`) because `crates/examples`
already enables `tokio = { features =
["full"] }`, and Cargo features are additive across
the workspace graph.
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
```sh
cargo test -p iceberg-sqllogictest
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
