mxm commented on code in PR #16065:
URL: https://github.com/apache/iceberg/pull/16065#discussion_r3162031044
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicIcebergSink.java:
##########
@@ -316,6 +321,26 @@ public Builder<T> writeParallelism(int
newWriteParallelism) {
return this;
}
+ public Builder<T> generatorSlotSharingGroup(SlotSharingGroup ssg) {
+ generatorSlotSharingGroup = ssg;
+ return this;
+ }
+
+ public Builder<T> shuffleSinkSlotSharingGroup(SlotSharingGroup ssg) {
+ shuffeSinkSlotSharingGroup = ssg;
+ return this;
+ }
+
+ /**
+ * Put generator and sink into each own's unique slot sharing group.
+ *
+ * @return {@link Builder} to connect the iceberg table.
+ */
+ public Builder<T> disableSlotSharing(boolean newDisableSlotSharing) {
+ disableSlotSharing = newDisableSlotSharing;
+ return this;
+ }
+
Review Comment:
Let' keep either the explicit slot sharing or the disable slot sharing
option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
