rambleraptor commented on code in PR #15795:
URL: https://github.com/apache/iceberg/pull/15795#discussion_r3164785665
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -77,6 +77,14 @@ protected boolean supportsBatchReads() {
return false;
}
+ /**
+ * Hook for subclasses to declare whether they support all types in the
given schema. Default is
+ * to support all schemas. If false is returned, the test will be skipped
using assumeTrue.
+ */
+ protected boolean supports(Schema schema) {
+ return true;
+ }
+
Review Comment:
I broke this up into a bunch of different schemas with the goal of trying to
have one schema per type (except for some primitives).
I'm hoping that can solve the problem. It did introduce a lot more
boilerplate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
