twuebi commented on code in PR #948:
URL: https://github.com/apache/iceberg-go/pull/948#discussion_r3166617778
##########
table/partitioned_fanout_writer_test.go:
##########
@@ -377,12 +383,19 @@ func (s *FanoutWriterTestSuite)
createComprehensiveTestRecord() arrow.RecordBatc
arrSchema := arrow.NewSchema(fields, nil)
idB := array.NewInt64Builder(pool)
+ defer idB.Release()
decB := array.NewDecimal128Builder(pool,
&arrow.Decimal128Type{Precision: 10, Scale: 6})
+ defer decB.Release()
timeB := array.NewTime64Builder(pool, &arrow.Time64Type{Unit:
arrow.Microsecond})
+ defer timeB.Release()
tsB := array.NewTimestampBuilder(pool, &arrow.TimestampType{Unit:
arrow.Microsecond})
+ defer tsB.Release()
tstzB := array.NewTimestampBuilder(pool, &arrow.TimestampType{Unit:
arrow.Microsecond, TimeZone: "UTC"})
+ defer tstzB.Release()
uuidB := extensions.NewUUIDBuilder(pool)
+ defer uuidB.Release()
dateB := array.NewDate32Builder(pool)
+ defer dateB.Release()
Review Comment:
changed to use record builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
