ebyhr commented on code in PR #16096:
URL: https://github.com/apache/iceberg/pull/16096#discussion_r3171628673
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -483,6 +483,18 @@ public void alterNamespace(String[] namespace,
NamespaceChange... changes)
@Override
public boolean dropNamespace(String[] namespace, boolean cascade)
throws NoSuchNamespaceException {
+ if (cascade) {
+ for (String[] ns : listNamespaces(namespace)) {
+ dropNamespace(ns, true);
+ }
Review Comment:
@singhpk234 I'm wondering whether this is really worth doing, since it
requires additional logic. Could you explain the motivation for dropping
namespaces last?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
