kevinjqliu commented on code in PR #3299:
URL: https://github.com/apache/iceberg-python/pull/3299#discussion_r3174076340
##########
tests/conftest.py:
##########
@@ -3036,7 +3036,6 @@ def ray_session() -> Generator[Any, None, None]:
ray.init(
ignore_reinit_error=True,
- runtime_env={"working_dir": None}, # Prevent Ray from serializing the
working directory to workers
Review Comment:
why is this removed?
##########
.github/workflows/python-ci.yml:
##########
@@ -97,6 +97,8 @@ jobs:
run: make install
- name: Run integration tests with coverage
run: COVERAGE=1 make test-integration
+ env:
+ RAY_ENABLE_UV_RUN_RUNTIME_ENV: "0"
Review Comment:
https://github.com/ray-project/ray/blob/1c7c90775cc56ced98ef24754e790e2d0d9c732e/python/ray/_private/ray_constants.py#L537-L549
should we set this in the `ray_session` test fixture instead?
##########
.github/workflows/svn-build-artifacts.yml:
##########
@@ -51,6 +51,7 @@ jobs:
3.11
3.12
3.13
+ 3.14
- name: Install UV
uses: astral-sh/setup-uv@5a095e7a2014a4212f075830d4f7277575a9d098 #
v7.3.1
Review Comment:
need to add this change
https://github.com/apache/iceberg-python/pull/2863/files#diff-bb2952d7690ed710b6927bf1489e2aaa93731daa68d49d67256e4c53411f7bc7R67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
