singhpk234 commented on code in PR #15977:
URL: https://github.com/apache/iceberg/pull/15977#discussion_r3175459883
##########
api/src/main/java/org/apache/iceberg/expressions/Literal.java:
##########
@@ -71,6 +71,18 @@ static Literal<BigDecimal> of(BigDecimal value) {
return new Literals.DecimalLiteral(value);
}
+ /**
+ * Returns a sentinel literal representing an explicit null default value.
Review Comment:
What stops this from being used in Predicates which are intentionally 2
valued, introducing this this way will make it prone to 3 valued boolean logic
? which i believe it will fail in the comparator later ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
