zhjwpku commented on code in PR #635: URL: https://github.com/apache/iceberg-cpp/pull/635#discussion_r3178394291
########## example/CMakeLists.txt: ########## @@ -26,5 +26,5 @@ find_package(iceberg CONFIG REQUIRED) add_executable(demo_example demo_example.cc) -target_link_libraries(demo_example PRIVATE iceberg::iceberg_bundle_static - iceberg::iceberg_rest_static) +target_link_libraries(demo_example PRIVATE iceberg::iceberg_bundle_shared Review Comment: I hadn't considered that. Should we set `ICEBERG_BUILD_SHARED=ON` and `ICEBERG_BUILD_STATIC=OFF`, or set both `ON`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
