kamcheungting-db commented on code in PR #624:
URL: https://github.com/apache/iceberg-cpp/pull/624#discussion_r3179386629
##########
src/iceberg/puffin/puffin_format.cc:
##########
@@ -36,6 +36,18 @@ constexpr std::pair<int, int> GetFlagPosition(PuffinFlag
flag) {
std::unreachable();
}
+} // namespace
Review Comment:
is there any reason to move both `Result<std::vector<std::byte>> Compress`
and `Result<std::vector<std::byte>> Decompress` out of the namespace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
