mxm commented on code in PR #16155:
URL: https://github.com/apache/iceberg/pull/16155#discussion_r3181271507
##########
flink/v2.1/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergStreamWriterMetrics.java:
##########
@@ -97,4 +101,58 @@ public Counter getFlushedDataFiles() {
public Counter getFlushedDeleteFiles() {
return flushedDeleteFiles;
}
+
+ @VisibleForTesting
+ Histogram dataFilesSizeHistogram() {
+ return dataFilesSizeHistogram;
+ }
+
+ @VisibleForTesting
+ Histogram deleteFilesSizeHistogram() {
+ return deleteFilesSizeHistogram;
+ }
+
+ private static Histogram registerHistogram(MetricGroup group, String name) {
+ Histogram histogram = newDropwizardHistogram();
+ return histogram != null ? group.histogram(name, histogram) : null;
+ }
+
+ private static Histogram newDropwizardHistogram() {
+ if (DROPWIZARD == null) {
+ return null;
+ }
+
+ Object reservoir =
DROPWIZARD.reservoirCtor.newInstance(HISTOGRAM_RESERVOIR_SIZE);
+ Object codahaleHistogram = DROPWIZARD.histogramCtor.newInstance(reservoir);
+ return DROPWIZARD.wrapperCtor.newInstance(codahaleHistogram);
+ }
+
+ private static DropwizardCtors loadDropwizardCtors() {
+ try {
+ Class<?> reservoirInterface =
Class.forName("com.codahale.metrics.Reservoir");
+ Class<?> codahaleHistogramClass =
Class.forName("com.codahale.metrics.Histogram");
Review Comment:
Thanks! Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
