Kurtiscwright commented on code in PR #16066:
URL: https://github.com/apache/iceberg/pull/16066#discussion_r3183724276
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkTypeToType.java:
##########
@@ -153,8 +154,12 @@ public Type atomic(DataType atomic) {
} else if (atomic instanceof DecimalType) {
return Types.DecimalType.of(
((DecimalType) atomic).precision(), ((DecimalType) atomic).scale());
+
Review Comment:
Yes, fixing in follow up commit.
##########
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkTypeToType.java:
##########
@@ -153,8 +154,12 @@ public Type atomic(DataType atomic) {
} else if (atomic instanceof DecimalType) {
return Types.DecimalType.of(
((DecimalType) atomic).precision(), ((DecimalType) atomic).scale());
+
Review Comment:
Yes, fixing in follow up commit.
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/ScanTestBase.java:
##########
@@ -95,14 +96,16 @@ protected void writeAndValidate(Schema writeSchema, Schema
expectedSchema) throw
HadoopTables tables = new HadoopTables(CONF);
// If V3 spec features are used, set the format version to 3
- Map<String, String> tableProperties =
+ boolean requiresV3 =
Review Comment:
I thought of keeping tests specific to versions, but thinking about it more
just setting properties to V3 would mean all the data types can be tested. Will
update in follow up commit.
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/ScanTestBase.java:
##########
@@ -95,11 +96,12 @@ protected void writeAndValidate(Schema writeSchema, Schema
expectedSchema) throw
HadoopTables tables = new HadoopTables(CONF);
// If V3 spec features are used, set the format version to 3
- Map<String, String> tableProperties =
+ boolean requiresV3 =
Review Comment:
Same as 3.5 path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
