kevinjqliu commented on code in PR #16107:
URL: https://github.com/apache/iceberg/pull/16107#discussion_r3196511651
##########
gcp-bundle/build.gradle:
##########
@@ -23,18 +23,13 @@ project(":iceberg-gcp-bundle") {
tasks.jar.dependsOn tasks.shadowJar
- configurations {
- implementation {
- exclude group: 'com.google.code.findbugs', module: 'jsr305'
- }
- }
-
dependencies {
implementation platform(libs.google.libraries.bom)
implementation "com.google.cloud:google-cloud-storage"
implementation "com.google.cloud:google-cloud-bigquery"
implementation "com.google.cloud:google-cloud-core"
implementation "com.google.cloud:google-cloud-kms"
+ implementation "com.google.cloud:google-cloud-monitoring"
Review Comment:
+1 #16103 + #16081 should enforce any runtime dep changes in CI, via
`[check-runtime-deps](https://github.com/apache/iceberg/actions/runs/25399058172/job/74493503774?pr=16107#logs)`
task
Theres also #16182 which is updating the LICENSE for GCP bundle.
Lets wait for all 3 PRs to land so we have a good baseline, and then we can
look at adding new deps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
