kevinjqliu commented on code in PR #2395:
URL: https://github.com/apache/iceberg-rust/pull/2395#discussion_r3204060972
##########
crates/iceberg/src/catalog/memory/catalog.rs:
##########
@@ -1888,7 +1888,7 @@ pub(crate) mod tests {
assert_eq!(table.identifier(), updated_table.identifier());
assert_eq!(table.metadata().uuid(), updated_table.metadata().uuid());
- assert!(table.metadata().last_updated_ms() <
updated_table.metadata().last_updated_ms());
+ assert!(table.metadata().last_updated_ms() <=
updated_table.metadata().last_updated_ms());
Review Comment:
based on what we discussed on the community sync today, my preference would
be to pick either
- remove this assertion, because it gives a false sense of invariance
regarding `last_updated_ms`
- keep `<=` but add a comment about allowing 1 min clock skew
i dont have a hard preference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
