varun-lakhyani commented on PR #16219: URL: https://github.com/apache/iceberg/pull/16219#issuecomment-4429906465
@steveloughran Thanks for review. I ran it against real s3, actually codebase doesn't have any benchmark against s3 so I didn't push the code but I made it easily configurable. To enable s3 benchmarking we need to override 2 function from baseclase IcebergCompactionBenchmark in IcebergDataCompactionBenchmark. Graphs posted in comments are against real s3 with below mentioned configs Storage: Amazon S3 (ap-south-1), FileIO: S3FileIO, rewrite strategy: rewrite-all=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
