rchowell commented on code in PR #2380:
URL: https://github.com/apache/iceberg-rust/pull/2380#discussion_r3230243815
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -297,15 +310,60 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)?;
+ // Check if the catalog table supports views, indicating that the
schema is V1
+ let is_v1 = sqlx::query(&format!(
+ "SELECT {CATALOG_FIELD_RECORD_TYPE} FROM {CATALOG_TABLE_NAME}
LIMIT 0"
+ ))
+ .execute(&pool)
+ .await
+ .is_ok();
+
+ // Migrate the schema to V1 if the catalog table does not support
views and the caller opted in.
+ let schema_version = if is_v1 {
+ tracing::debug!("{CATALOG_TABLE_NAME} already supports views");
Review Comment:
I used the same logging messages and names as iceberg-java. Happy to change
it to something more clear.
##########
crates/catalog/sql/src/catalog.rs:
##########
@@ -297,15 +310,60 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)?;
+ // Check if the catalog table supports views, indicating that the
schema is V1
+ let is_v1 = sqlx::query(&format!(
+ "SELECT {CATALOG_FIELD_RECORD_TYPE} FROM {CATALOG_TABLE_NAME}
LIMIT 0"
+ ))
+ .execute(&pool)
+ .await
+ .is_ok();
+
+ // Migrate the schema to V1 if the catalog table does not support
views and the caller opted in.
+ let schema_version = if is_v1 {
+ tracing::debug!("{CATALOG_TABLE_NAME} already supports views");
+ SchemaVersion::V1
+ } else {
+ let requested: SchemaVersion = config
+ .props
+ .get(SQL_CATALOG_PROP_SCHEMA_VERSION)
+ .and_then(|v| v.parse().ok())
+ .unwrap_or(SchemaVersion::V0);
+ if requested == SchemaVersion::V1 {
+ tracing::debug!("{CATALOG_TABLE_NAME} is being updated to
support views");
Review Comment:
I used the same logging messages and names as iceberg-java. Happy to change
it to something more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
