CTTY commented on code in PR #2188: URL: https://github.com/apache/iceberg-rust/pull/2188#discussion_r3230536366
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -42,6 +42,11 @@ pub const MAP_KEY_FIELD_NAME: &str = "key"; /// Field name for map type's value. pub const MAP_VALUE_FIELD_NAME: &str = "value"; +/// Minimum format version required for nanosecond-precision timestamp types (v3). +pub const MIN_FORMAT_VERSION_TIMESTAMP_NS: FormatVersion = FormatVersion::V3; +/// Minimum format version required for the variant type (v3). +pub const MIN_FORMAT_VERSION_VARIANT: FormatVersion = FormatVersion::V3; Review Comment: nit: These are not really needed, since the min versions of these types should be hardcoded to FormatVersion::V3 anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
