dhananjaykrutika opened a new pull request, #1076: URL: https://github.com/apache/iceberg-go/pull/1076
DeleteOrphanFiles builds "referenced files" set by walking each live snapshot's manifests, fetching every entry with discardDeleted=false, and unconditionally marking entry as referenced. This treats DELETED-status entries (tombstones) the same as ADDED/EXISTING entries, so any data file that had ever been overwritten or deleted in a copy-on-write operation remains referenced by the surviving snapshot's tombstone manifest. After every snapshot that actually held the file live is expired, the file is still reachable and orphan cleanup skips it. This is a deviation from iceberg-java and iceberg-python implementations. Switch manifest.Entries() to use discardDeleted=true so tombstones are excluded before they reach the reference-collection loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
