nastra commented on code in PR #16190:
URL: https://github.com/apache/iceberg/pull/16190#discussion_r3235205062
##########
core/src/main/java/org/apache/iceberg/actions/BinPackRewriteFilePlanner.java:
##########
@@ -91,6 +91,19 @@ public class BinPackRewriteFilePlanner
*/
public static final String MAX_FILES_TO_REWRITE = "max-files-to-rewrite";
+ /**
+ * Controls whether to rewrite files written with a partition spec different
from the configured
+ * output spec.
+ *
+ * <p>This can be used to migrate files created before partition spec
evolution (for example, when
+ * the spec evolved from month to month plus day).
+ *
+ * <p>Defaults to false.
+ */
+ public static final String REWRITE_PARTITION_SPEC_MISMATCH =
"rewrite-partition-spec-mismatch";
Review Comment:
thanks for updating the PR description as that helps understanding your use
case better. In this case I think it might make sense to gate this behind a
flag but it would be good to get more feedback from the community. Maybe raise
a thread on the DEV mailing list about this to get a few more folks to review
this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
