alessandro-nori commented on code in PR #1062: URL: https://github.com/apache/iceberg-go/pull/1062#discussion_r3289027636
########## io/config.go: ########## @@ -43,12 +43,14 @@ const ( // Constants for Azure configuration options const ( - ADLSSasTokenPrefix = "adls.sas-token." - ADLSConnectionStringPrefix = "adls.connection-string." - ADLSSharedKeyAccountName = "adls.auth.shared-key.account.name" - ADLSSharedKeyAccountKey = "adls.auth.shared-key.account.key" - ADLSEndpoint = "adls.endpoint" - ADLSProtocol = "adls.protocol" + ADLSSasTokenPrefix = "adls.sas-token." + ADLSConnectionStringPrefix = "adls.connection-string." + ADLSSharedKeyAccountName = "adls.auth.shared-key.account.name" + ADLSSharedKeyAccountKey = "adls.auth.shared-key.account.key" + ADLSEndpoint = "adls.endpoint" + ADLSProtocol = "adls.protocol" + ADLSManagedIdentityEnabled = "adls.auth.managed-identity.enabled" + ADLSManagedIdentityClientID = "adls.auth.managed-identity.client-id" Review Comment: > A REST catalog vending creds from Java will never emit them, so this branch is effectively unreachable in any cross-client deployment These properties are not used in the context of credentials vending but when the client has already access to the container, so it's not true that the branch is unreachable. Ok for the `client-id` key -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
