ndrluis opened a new pull request, #3409: URL: https://github.com/apache/iceberg-python/pull/3409
# Rationale for this change While reviewing https://github.com/apache/iceberg-python/pull/3387, I found a missing regression test for upsert behavior when a table is partitioned by a column that is not part of `join_cols`, and the source row changes that partition column value. For example, if the table is partitioned by `order_date` but the upsert matches rows using only `order_id`, an existing row should still be matched by `order_id` even when the incoming row has a different `order_date`. The expected behavior is that the row is updated and moved to the new partition, not treated as a new insert. Regardless of whether #3387 is merged, I believe this behavior should be protected in the repository because partition pruning optimizations in this area can otherwise accidentally prune away the existing target row before the join-key match is evaluated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
