singhpk234 commented on code in PR #16525:
URL: https://github.com/apache/iceberg/pull/16525#discussion_r3295387819
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -484,6 +488,13 @@ public void commit() {
update.setBranchSnapshot(newSnapshot, targetBranch);
}
+ EncryptionManager encryptionManager = ops.encryption();
+ if (encryptionManager instanceof StandardEncryptionManager) {
+ Map<String, EncryptedKey> keys =
+ EncryptionUtil.encryptionKeys(encryptionManager);
+ keys.values().forEach(update::addEncryptionKey);
Review Comment:
wait, are we saying we are not adding the manifest list key in the
encryptions keys in TableMetadata ?
so decryption fail ?
orthogonally `EncryptionUtil.encryptionKeys(encryptionManager);` gives all
keys or just keys for the current snapshot ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
