sungwy commented on PR #16524: URL: https://github.com/apache/iceberg/pull/16524#issuecomment-4530423347
Hi @wombatu-kun - thanks for working on this PR. I think it would be good to scope SIGNED_COMPONENT_CACHE at the instance level as well. With the current change, authManager and httpClient are isolated per S3V4RestSignerClient instance, but the cache is still static and shared across the JVM. https://github.com/apache/iceberg/blob/23c7f231a2e8b8197d4cbecf04a23d66bc033b46/aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java#L96-L97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
