moomindani commented on PR #16250: URL: https://github.com/apache/iceberg/pull/16250#issuecomment-4531242669
Pushed `4461830a9` addressing the cardinality and combined-reporter test points raised by @vaquar on the [dev@ thread](https://lists.apache.org/thread/vn4gglocg2g40p69mfrrh86qzkn1rr4b): - `iceberg.snapshot.id` is no longer attached as a metric attribute. Snapshot ids are monotonically increasing and unique per commit, so attaching them risks unbounded cardinality in any time-series backend. Bounded attribute set is now: scan = `iceberg.table.name` + `iceberg.schema.id`; commit = `iceberg.table.name` + `iceberg.operation`. A new "Cardinality" section in the reporter's Javadoc documents the trade-off. - New `testCombinedWithAnotherReporter` exercises `MetricsReporters.combine(otelReporter, otherReporter)` and verifies both reporters receive `ScanReport` and `CommitReport`. - New `testSnapshotIdIsNotAMetricAttribute` asserts the bounded attribute set on emitted data points. Replying on the dev@ thread separately about @rdblue's usability question (OTel API packaging) and module placement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
