plusplusjiajia commented on PR #616:
URL: https://github.com/apache/iceberg-cpp/pull/616#issuecomment-4533418678
Thanks for the thorough review @wgtmac! Pushed a commit addressing your 5/21
feedback:
- Concurrency: counter under mutex, RAII session slot, no more TOCTOU.
- Perf: cached SDK region resolution, derived sessions reuse parent
credentials, O(N+M) header relocation.
- Java parity: new SessionContext (properties + credentials), new
HttpHeaders (case-insensitive multi-value), legacy rest.sigv4-enabled honored.
- CMake: generic ICEBERG_FIND_EXTRA_ARGS_<dep> instead of AWSSDK special
case.
- CI: aws_test.yml merges S3 + SigV4 in one job to verify SDK coexistence.
Base64 in x-amz-content-sha256 — re-confirmed Java's
SignerChecksumParams.checksumHeaderName path also outputs Base64 (via
BinaryUtils.toBase64), so this is intentional parity.
PTAL when you get a chance, thanks again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
