rdblue commented on a change in pull request #1906:
URL: https://github.com/apache/iceberg/pull/1906#discussion_r540561987
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -76,6 +76,7 @@ callArgument
expression
: constant
+ | stringMap
Review comment:
Looks like this is intended to mimic the [`map`
function](https://spark.apache.org/docs/latest/api/sql/#map)?
If so, should this allow any constant for keys and values? I would expect
something like this:
```
mapLiteral
: MAP '(' pairs+=keyValue, (',' pairs+=keyValue)* ')'
;
keyValue
: key=constant ',' value=constant
;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
