happydave1 commented on PR #1138: URL: https://github.com/apache/iceberg-go/pull/1138#issuecomment-4703033952
Thanks for the comments and review guys. I went through and should have addressed all comments for this round. 1) Fixed the lowercase slicing bug in `icebergCRSToGeoArrowMetadata` by slicing the original `crs` instead of `lowerCRS` 2) Moved `WKTToWKB` to `geo_codec_test.go` to remove `go-geom` as a production dependency 3) Added an error case to `TestWKTToWKB`, also adding error wrapping in `wktToWKB` 4) cleaned up dead arms in `geoArrowCRSToIcebergCRS` Thank you again for the catches and let me know if I missed anything. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
