Guosmilesmile commented on PR #16724: URL: https://github.com/apache/iceberg/pull/16724#issuecomment-4704064673
Here's a summary of the recent changes: * Split the test cases into two directions: AES and NATIVE. Avro supports AES encryption, Parquet supports the NATIVE approach, and ORC supports neither. * keyMetadata(...): saves the encryption metadata to the DataFile, mainly used by the read side for decryption — it's not an encryption switch. * withFileEncryptionKey(...): passes in the actual file encryption key; Parquet native encryption relies on this to trigger encryption of the file content. * withAADPrefix(...): passes in the AAD prefix, which participates in authentication / tamper protection, and must be paired with the encryption key. If you all have time, please continue to help with further review. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
