nastra commented on PR #16029: URL: https://github.com/apache/iceberg/pull/16029#issuecomment-4727332964
@sahmadov I took another look at your proposed fix and while it seems to make sense on a first look, I think there is a general issue. Let me summarize my thinking below: * you have a custom catalog with `class IometeJDBCTableCatalog extends JDBCTableCatalog with ViewCatalog` which effectively implements Spark's DSv2 `ViewCatalog` * there is currently no code in Spark itself that deals with DSv2 View operations and you would fail with something like `[MISSING_CATALOG_ABILITY.VIEWS] Catalog xyz does not support views.` * even if you have a non-iceberg view catalog, it wouldn't work and fail with the error above The idea was that the entire machinery that currently exists for DSv2 views in Iceberg will eventually be ported to Spark in order to natively support DSv2 views. Once this lands in Spark, the machinery in Iceberg will be removed. Let me know if that makes sense to you. Also /cc @huaxingao or @amogh-jahagirdar in case they have any other observations here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
