stark256-spec commented on PR #3454: URL: https://github.com/apache/iceberg-python/pull/3454#issuecomment-4747218180
Pushed in 3883280e: - **`FetchNextPage` alias**: extracted into a named `TypeAlias` in `typedef.py` (`FetchNextPage: TypeAlias = Callable[[str], tuple[list[T], str | None]]`) and used in `PaginationList.__init__`. Future paginated endpoints can annotate their callbacks as `FetchNextPage[Identifier]` instead of repeating the inline signature. - **HTTP call count**: both integration tests now wrap `catalog._session.get` and assert `mock_get.call_count == len(result)` (namespaces) / `== len(table_list)` (tables). That way if the REST fixture ignores `rest-page-size` and returns everything on the first call, the assertion fails rather than silently passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
