kevinjqliu commented on PR #3500: URL: https://github.com/apache/iceberg-python/pull/3500#issuecomment-4760285447
> Compared this to Java RESTSessionCatalog and VendedCredentialsProvider. They don't call the /credentials api during loadTable and instead seems to rely on inline storage-credentials on load_table call, and uses the credential endpoint for refresh in FileIO. yea i realized that. I thought the fallback is cheeky, but it diverges from the java implementation. I dont want to create subtle behavioral difference. loadTable should expect credentials from the inline `storage-credentials` in response and `/credentials` should be used by refresh directly. this also aligns with what @gabeiglio mentioned here: https://github.com/apache/iceberg-python/pull/3499#issuecomment-4709194999 I'm going to close this PR in favor of #3507, which should properly use the `/crendentials` endpoint for FileIO refresh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
