zeroshade commented on code in PR #58: URL: https://github.com/apache/terraform-provider-iceberg/pull/58#discussion_r3454621672
########## .pre-commit-config.yaml: ########## @@ -15,12 +15,9 @@ # specific language governing permissions and limitations # under the License. --- -files: ^go/ - repos: - - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.4.0 + - repo: https://github.com/golangci/golangci-lint + rev: v2.8.0 Review Comment: ```suggestion rev: c0d3ddc9cf3faa61a4e378e879ece580256d76e5 # frozen: v2.12.2 ``` ########## .pre-commit-config.yaml: ########## @@ -15,12 +15,9 @@ # specific language governing permissions and limitations # under the License. --- -files: ^go/ - repos: - - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.4.0 + - repo: https://github.com/golangci/golangci-lint + rev: v2.8.0 hooks: - id: golangci-lint - entry: bash -c 'cd iceberg && golangci-lint run --fix --timeout 5m' - types_or: [go] Review Comment: don't get rid of the `types_or` line if we're gonna have it pass the filenames. Should probably make this `types_or: [go, go-mod]` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
