pvary commented on code in PR #16345:
URL: https://github.com/apache/iceberg/pull/16345#discussion_r3461252617
##########
orc/src/test/java/org/apache/iceberg/orc/TestTableProperties.java:
##########
@@ -54,23 +54,15 @@ public class TestTableProperties {
@TempDir private File testFile;
@Test
- public void testOrcTableProperties() throws Exception {
- Random random = new Random();
- int numOfCodecs = CompressionKind.values().length;
- int numOfStrategies = CompressionStrategy.values().length;
-
- long stripeSizeBytes = 32L * 1024 * 1024;
- long blockSizeBytes = 128L * 1024 * 1024;
- String codecAsString =
CompressionKind.values()[random.nextInt(numOfCodecs)].name();
- String strategyAsString =
CompressionStrategy.values()[random.nextInt(numOfStrategies)].name();
+ public void testOrcTablePropertiesForDataFile() throws Exception {
+ String codecAsString = CompressionKind.SNAPPY.name();
ImmutableMap<String, String> properties =
ImmutableMap.of(
- TableProperties.ORC_STRIPE_SIZE_BYTES,
String.valueOf(stripeSizeBytes),
- TableProperties.ORC_BLOCK_SIZE_BYTES,
String.valueOf(blockSizeBytes),
Review Comment:
How do these values get to the the writer? Shall we move the tests to
actually validate that code path instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
