yyanyy commented on a change in pull request #1946:
URL: https://github.com/apache/iceberg/pull/1946#discussion_r546145537
##########
File path: api/src/main/java/org/apache/iceberg/FieldMetrics.java
##########
@@ -30,15 +28,15 @@
private final long valueCount;
private final long nullValueCount;
private final long nanValueCount;
- private final ByteBuffer lowerBound;
- private final ByteBuffer upperBound;
+ private final Object lowerBound;
+ private final Object upperBound;
Review comment:
I was mostly following the pattern of ORC and Parquet to evaluate
metrics mode when collecting metrics (which has to be since the file formats
collects stats themselves), but I think there's nothing prevent us from
ingesting metrics mode during value writers creation, it will just make the
visitor pattern a little bit more complicated. I'll give it a try, and thanks
for bringing up this idea!
I guess for now I'll revert the change to `FieldMetrics` in this PR and
include it in the next one that updates value writers if we need to change it.
Hopefully that doesn't add too much to the next PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
