openinx commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r546534299
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java
##########
@@ -83,8 +83,8 @@ public void testGetTable() {
Types.NestedField.optional(1, "strV", Types.StringType.get())));
Assert.assertEquals(
Arrays.asList(
- TableColumn.of("id", DataTypes.BIGINT()),
- TableColumn.of("strV", DataTypes.STRING())),
+ TableColumn.physical("id", DataTypes.BIGINT()),
Review comment:
It's strange here, because I saw the `TableColumn` is marked as
`PublicEvolving`, but after released flink 1.12.0 it did not have any Interface
compatibility guarantee. At least, it should marked as `deprecated`, and keep
it a major release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
