rdblue commented on a change in pull request #1823:
URL: https://github.com/apache/iceberg/pull/1823#discussion_r547555643
##########
File path: aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java
##########
@@ -198,6 +243,19 @@ public AwsProperties(Map<String, String> properties) {
this.s3FileIoAcl = ObjectCannedACL.fromValue(aclType);
Preconditions.checkArgument(s3FileIoAcl == null ||
!s3FileIoAcl.equals(ObjectCannedACL.UNKNOWN_TO_SDK_VERSION),
"Cannot support S3 CannedACL " + aclType);
+
+ this.glueCatalogLockEnabled = PropertyUtil.propertyAsBoolean(properties,
+ GLUE_CATALOG_LOCK_ENABLED, GLUE_CATALOG_LOCK_ENABLED_DEFAULT);
+ this.glueCatalogLockTable = properties.get(GLUE_CATALOG_LOCK_TABLE);
+ this.glueCatalogLockWaitMs = PropertyUtil.propertyAsLong(properties,
+ GLUE_CATALOG_LOCK_WAIT_MS, GLUE_CATALOG_LOCK_WAIT_MS_DEFAULT);
+ this.glueCatalogLockExpireMs = PropertyUtil.propertyAsLong(properties,
+ GLUE_CATALOG_LOCK_MS_EXPIRE, GLUE_CATALOG_LOCK_EXPIRE_MS_DEFAULT);
+
+ if (glueCatalogLockEnabled) {
+ Preconditions.checkNotNull(glueCatalogLockTable,
+ GLUE_CATALOG_LOCK_TABLE + " must not be null with GLue catalog lock
is enabled");
Review comment:
Typo: "GLue" -> "Glue"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
