Fokko commented on a change in pull request #1972:
URL: https://github.com/apache/iceberg/pull/1972#discussion_r548268009
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -58,9 +58,11 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class HiveCatalog extends BaseMetastoreCatalog implements Closeable,
SupportsNamespaces {
+public class HiveCatalog extends BaseMetastoreCatalog implements
AutoCloseable, SupportsNamespaces {
Review comment:
I was under the impression that we couldn't use `with { } `. But this
seems incorrect. I'll revert this change. Thanks for pointing it out, so we can
keep the history clean 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
