rdblue commented on a change in pull request #1996:
URL: https://github.com/apache/iceberg/pull/1996#discussion_r549462998
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/sink/BaseDeltaTaskWriter.java
##########
@@ -70,6 +73,9 @@ public void write(RowData row) throws IOException {
switch (row.getRowKind()) {
case INSERT:
case UPDATE_AFTER:
+ if (upsert) {
Review comment:
It seems like this should only happen for the `INSERT` case because
`UPDATE_AFTER` implies that there was an `UPDATE_BEFORE` that will perform the
delete. This would delete the same row twice in that case, causing more
equality deletes to be written for the row.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
