thswlsqls opened a new pull request, #17246: URL: https://github.com/apache/iceberg/pull/17246
Closes #17245 ## Summary - `AssumeRoleAwsClientFactory.s3()` skipped `applyS3AccessGrantsConfigurations` and `applyUserAgentConfigurations`, so assume-role S3 clients ignored `s3.access-grants.enabled` and never set the `s3fileio/` user agent. - This PR applies both in the same order as the sibling [`DefaultAwsClientFactory.s3()`](https://github.com/apache/iceberg/blob/main/aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java#L108-L122): signer -> access grants -> user agent -> retry. - Independent scope: this covers the s3 access-grants/user-agent parity gap only, separate from open PR #17049 by the same author, which changes the same files for glue/kms endpoint config. ## Testing done - Added `TestAwsClientFactories#testAssumeRoleAwsClientFactoryS3AppliesUserAgent` (asserts the built S3 client's user agent prefix starts with `s3fileio/`) and `#testAssumeRoleAwsClientFactoryS3AppliesS3AccessGrants` (builds `s3()` with access grants enabled). - `./gradlew :iceberg-aws:spotlessCheck :iceberg-aws:test --tests "org.apache.iceberg.aws.TestAwsClientFactories"` — 23 tests passed, 0 failed. - Full `:iceberg-aws:check` was not run: it pulls in testcontainers/Docker integration tests that do not complete locally. aws is not a revapi module, so revapi is skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
