HenryCaiHaiying commented on code in PR #17025:
URL: https://github.com/apache/iceberg/pull/17025#discussion_r3612458381
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/channel/Coordinator.java:
##########
@@ -123,6 +129,7 @@ void process() {
Event event =
new Event(config.connectGroupId(), new
StartCommit(commitState.currentCommitId()));
send(event);
+ coordinatorMetrics.incStartCommit();
Review Comment:
I want to count 'events successfully emitted' and will leave a note with the
metric description. This way it is consistent with the logging of 'Coordinator
{} initiated commit {}' on the next line. Same for Worker.receive()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
