SreeramGarlapati commented on PR #2540: URL: https://github.com/apache/iceberg-rust/pull/2540#issuecomment-5022877262
@xanderbailey rebased onto latest main, ci green. i think both your points are covered above: - `isDigit`: staying ascii-strict on purpose — matching Java's unicode `isDigit` would re-introduce the exact invalid-avro-name case this pr fixes, and cross-engine correctness is by field-id anyway, so representational parity isn't needed. - avro-rs `validate_record_field_name`: kept the local 6-line check since it's zero-coupling and also covers the `iceberg-field-name` sanitize half that avro-rs doesn't. happy to file an upstream issue to expose their validator as a good-citizen follow-up if u want it. anything else blocking here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
