tanmayrauth commented on PR #1430:
URL: https://github.com/apache/iceberg-go/pull/1430#issuecomment-5025575659
@zeroshade Thanks for the re-review! Both follow-ups handled:
For catalog.Closer contract for the registry-loaded SQL catalog - good
catch, I've fixed it. Added an ownsDB flag set only on the registrar path
(which does its own sql.Open); Close() now closes that owned handle in addition
to releasing the reporter. Caller-supplied handles passed to NewCatalog stay
ownsDB=false and are left open as before. Doc comment on Close() updated to
describe both cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
