rdblue commented on a change in pull request #1981:
URL: https://github.com/apache/iceberg/pull/1981#discussion_r549822454
##########
File path: api/src/main/java/org/apache/iceberg/transforms/Timestamps.java
##########
@@ -52,12 +52,19 @@ public Integer apply(Long timestampMicros) {
return null;
}
- // discards fractional seconds, not needed for calculation
- OffsetDateTime timestamp = Instant
- .ofEpochSecond(timestampMicros / 1_000_000)
- .atOffset(ZoneOffset.UTC);
-
- return (int) granularity.between(EPOCH, timestamp);
+ if (timestampMicros >= 0) {
+ OffsetDateTime timestamp = Instant
+ .ofEpochSecond(Math.floorDiv(timestampMicros, 1_000_000),
Math.floorMod(timestampMicros, 1_000_000))
+ .atOffset(ZoneOffset.UTC);
+ return (int) granularity.between(EPOCH, timestamp);
+ } else {
+ // add 1 micro to the value to account for the case where there is
exactly 1 unit between the timestamp and epoch
+ // because the result will always be decremented.
+ OffsetDateTime timestamp = Instant
+ .ofEpochSecond(Math.floorDiv(timestampMicros, 1_000_000),
Math.floorMod(timestampMicros + 1, 1_000_000))
Review comment:
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
